Closed irvingoujAtDevolution closed 6 months ago
Unfortunately we can't change
is_connect_failed
as that would be a breaking change. So we have to keep the name the same there.
I apologize for my previous mistake. I would like to have your opinion on whether it is better to add is_err
, mark is_connect_fail
as deprecated, or simply keep using the same name but change the implementation.
I would argue that the first approach is better, as it aligns with the semantics it provides.
I apologize for my previous mistake. I would like to have your opinion on whether it is better to add
is_err
, markis_connect_fail
as deprecated, or simply keep using the same name but change the implementation.I would argue that the first approach is better, as it aligns with the semantics it provides.
I'd argue that the first would be better.
please have a look again, I am not exactly sure if this is how you want it.
😢 , @notgull could you please help me look at the wine CI thing? I have no idea how that works
Looks like a spurious error.
In linux, epoll, EPOLLHUP may happen even if no connection call is made. It would confuse callers for what is actually happening. Replaced is_connect_failed, and we detect if connection failed by using the combination of is_err and is_interrupt, please see the example, tcp_client