smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.64k stars 404 forks source link

split smoltcp in smolutils, smolwire and smoltcp #812

Closed thvdveld closed 7 months ago

thvdveld commented 1 year ago

This splits smoltcp into 3 crates.

smolutils

This contains logic that is shared between smolwire and smoltcp. The logic that is shared is time and some parts of phy, such as ChecksumCapabilities and Medium. I don't think this crate should be released or something (I'm not sure since I never actually released big crates).

smolwire

This crate contains logic for parsing and emitting IP packets. This crate should be released, since this contains useful parsing structures, not only for smoltcp but also for other use cases.

I named it smolwire since the structures were in the wire module. Maybe smolpackets is better, as suggested in #811 ?

smoltcp

This is the TCP/IP library of smoltcp.

TODO

codecov[bot] commented 1 year ago

Codecov Report

Merging #812 (8180cbc) into main (7ff1364) will decrease coverage by 0.03%. The diff coverage is 52.12%.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   79.65%   79.63%   -0.03%     
==========================================
  Files          72       75       +3     
  Lines       27862    27854       -8     
==========================================
- Hits        22193    22181      -12     
- Misses       5669     5673       +4     
Impacted Files Coverage Δ
smoltcp/src/iface/fragmentation.rs 91.44% <ø> (ø)
smoltcp/src/iface/interface/ethernet.rs 91.48% <ø> (ø)
smoltcp/src/iface/interface/ieee802154.rs 88.75% <ø> (ø)
smoltcp/src/iface/interface/igmp.rs 50.57% <ø> (ø)
smoltcp/src/iface/interface/ipv4.rs 68.23% <0.00%> (ø)
smoltcp/src/iface/interface/ipv6.rs 90.95% <0.00%> (ø)
smoltcp/src/iface/ip_packet.rs 54.12% <ø> (ø)
smoltcp/src/iface/neighbor.rs 98.00% <ø> (ø)
smoltcp/src/iface/route.rs 71.35% <ø> (ø)
smoltcp/src/iface/rpl/lollipop.rs 98.36% <ø> (ø)
... and 65 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thvdveld commented 7 months ago

Going to close this as this would add more maintenance overhead (for the smoltcp team) compared to a single crate.