search

smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.64k stars 404 forks source link

fix(ndisc): prevent ndisc when medium is IP. #865

Closed thvdveld closed 7 months ago

thvdveld commented 7 months ago

When the medium-ip feature, and medium-ethernet or medium-ieee802154 is enabled, it was possible to receive an ICMP NDISC message. This made smoltcp panic as it tried to conver the HardwareAddress::Ip to a RawHardwareAddress.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (36a143d) 79.62% compared to head (5a3ed88) 79.63%. Report is 2 commits behind head on main.

Files Patch % Lines
src/iface/interface/mod.rs 80.00% 2 Missing :warning:
src/iface/interface/ipv6.rs 88.88% 1 Missing :warning:
src/socket/dns.rs 0.00% 1 Missing :warning:
src/socket/udp.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #865 +/- ## ========================================== + Coverage 79.62% 79.63% +0.01% ========================================== Files 78 78 Lines 28043 28051 +8 ========================================== + Hits 22329 22339 +10 + Misses 5714 5712 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.