search

smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.75k stars 421 forks source link

Ipv6RoutingHeader::clear_reserved: fix offsets for Type 2 routing headers. #882

Closed luqmana closed 9 months ago

luqmana commented 9 months ago

Noticed this off-by-2, bytes 6 & 7 are part of the Home Address field not the Reserved portion.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4e2f477) 79.77% compared to head (6eccf51) 79.77%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #882 +/- ## ======================================= Coverage 79.77% 79.77% ======================================= Files 78 78 Lines 28133 28133 ======================================= Hits 22443 22443 Misses 5690 5690 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thvdveld commented 9 months ago

Thank you! I updated the emit test to make sure that this is not missed when changes are made to the logic.

luqmana commented 9 months ago

Thank you! I updated the emit test to make sure that this is not missed when changes are made to the logic.

Thanks!