Closed thvdveld closed 6 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
3f2a219
) 79.77% compared to head (892d4d9
) 79.71%.
Files | Patch % | Lines |
---|---|---|
src/wire/ethernet.rs | 0.00% | 1 Missing :warning: |
src/wire/sixlowpan/frag.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This ensures that no accessor methods are valid…
“Invalid”?
Oh damn, yes, that's what I wanted to write...
This commit adds a call to
check_len
to all parse methods in thewire
module. This ensures that no accessor methods are invalid, helping the compiler optimise.server: 199.4KiB -> 197.3KiB client: 200.2KiB -> 198.0KiB sixlowpan: 196.8KiB -> 194.7KiB
It's a small gain, but it's worth it.
Edit: valid -> invalid