search

smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.63k stars 402 forks source link

fix: accept any ip for IPv6 #900

Closed thvdveld closed 1 month ago

thvdveld commented 5 months ago

Fixes #899 .

However, I'm not sure if this is the intended behaviour of Any IP. Should we check if the packet is routed locally, or should we just accept any packet?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9bd836b) 79.92% compared to head (f5286f5) 79.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #900 +/- ## ========================================== + Coverage 79.92% 79.94% +0.02% ========================================== Files 80 80 Lines 28234 28238 +4 ========================================== + Hits 22566 22576 +10 + Misses 5668 5662 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mhils commented 1 month ago

@thvdveld: Thank you so much! 🍰 I was just looking into this issue when upgrading smoltcp in https://github.com/mitmproxy/mitmproxy_rs, what a fantastic timing. 🤩 Thank you for your work! ❤️