smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.63k stars 402 forks source link

Re-export `dhcpv4::Flags` and `dhcpv4::OpCode` #901

Closed Databean closed 5 months ago

Databean commented 5 months ago

Similar to issue #762 and PR #763, DhcpPacket::set_flags and DhcpPacket::set_opcode were not usable externally because dhcpv4::Flags and dhcpv4::OpCode were private types. Re-export these types as smoltcp::wire::DhcpFlags and smoltcp::wire::DhcpOpCode.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9bd836b) 79.92% compared to head (9c422f8) 79.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #901 +/- ## ======================================= Coverage 79.92% 79.92% ======================================= Files 80 80 Lines 28234 28234 ======================================= Hits 22566 22566 Misses 5668 5668 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thvdveld commented 5 months ago

Thank you!