search

smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.63k stars 402 forks source link

Use `core` instead of `std` for net types. #937

Closed liamkinne closed 1 month ago

liamkinne commented 1 month ago

Helpful for using .into() with these types on no_std platforms.

liamkinne commented 1 month ago

To fix MSRV should this be gated behind an ip_in_core feature?

Dirbaio commented 1 month ago

IMO we can just increase the MSRV, unless someone has some objection.

liamkinne commented 1 month ago

Have brought the msrv up. If it's okay, I will fix the clippy lints in another PR to not pollute this one with unrelated changes.

crawford commented 1 month ago

Bumping the MSRV brings with it the changes to Clippy's lints. In my opinion, it's fine to have the linting changes in this PR. If they're done in a separate commit, it's still easy to follow.

liamkinne commented 1 month ago

Ready for review.

Dirbaio commented 1 month ago

there's more places where MSRV should be updated, like the readme. please grep for "1.65" and update them all.