Closed tomDev5 closed 5 days ago
Looks good at a quick glance.
Hi, I would appreciate if someone could review this PR (or approve if it indeed looks good)
Attention: Patch coverage is 93.36493%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 79.21%. Comparing base (
6c06cd9
) to head (b4c0779
). Report is 31 commits behind head on main.:exclamation: Current head b4c0779 differs from pull request most recent head 89e8265
Please upload reports for the commit 89e8265 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/wire/tcp.rs | 73.58% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok, the codecov window is refusing to update. all complained upon lines are integrated in tests
Ok, the codecov window is refusing to update.
Yeah so codecov is having some infra issues. That's ok. I talked to their CTO, they'll fix it eventually but not yet.
Agreed, that made for cleaner access.
I'm on vacation for a week. Later!
@whitequark gentle ping, regarding the fixes I've made
This is currently not relating to the RTT estimation, just for supporting remotes who do support it. The generator isn't a lambda to avoid a generic. Tests include a logic test of an established session and tests which make sure this option is only enabled if the both sides support it.