smoltcp-rs / smoltcp

a smol tcp/ip stack
BSD Zero Clause License
3.63k stars 402 forks source link

Support TCP Timestamp option #939

Closed tomDev5 closed 5 days ago

tomDev5 commented 1 month ago

This is currently not relating to the RTT estimation, just for supporting remotes who do support it. The generator isn't a lambda to avoid a generic. Tests include a logic test of an established session and tests which make sure this option is only enabled if the both sides support it.

whitequark commented 3 weeks ago

Looks good at a quick glance.

tomDev5 commented 2 weeks ago

Hi, I would appreciate if someone could review this PR (or approve if it indeed looks good)

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 93.36493% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (6c06cd9) to head (b4c0779). Report is 31 commits behind head on main.

:exclamation: Current head b4c0779 differs from pull request most recent head 89e8265

Please upload reports for the commit 89e8265 to get more accurate results.

Files Patch % Lines
src/wire/tcp.rs 73.58% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #939 +/- ## ========================================== - Coverage 79.97% 79.21% -0.77% ========================================== Files 81 81 Lines 27831 26820 -1011 ========================================== - Hits 22259 21245 -1014 - Misses 5572 5575 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tomDev5 commented 2 weeks ago

Ok, the codecov window is refusing to update. all complained upon lines are integrated in tests

whitequark commented 2 weeks ago

Ok, the codecov window is refusing to update.

Yeah so codecov is having some infra issues. That's ok. I talked to their CTO, they'll fix it eventually but not yet.

tomDev5 commented 2 weeks ago

Agreed, that made for cleaner access.

whitequark commented 2 weeks ago

I'm on vacation for a week. Later!

tomDev5 commented 6 days ago

@whitequark gentle ping, regarding the fixes I've made