search

smondet / trakeva

Transactions, Keys, and Values
http://www.hammerlab.org/docs/trakeva/master/index.html
24 stars 3 forks source link

New sub-lib: Trakeva_of_uri #18

Closed smondet closed 9 years ago

smondet commented 9 years ago

Intense first class modules and build system hacking …

Review on Reviewable

smondet commented 9 years ago

Running Ketrew over Postgresql here with https://github.com/hammerlab/ketrew/commit/2256f19e654450c50fb7165953d0b1a8520e38fb

rleonid commented 9 years ago

Modulo the points I've made above it looks good. It is a real shame that you have to jump through such hoops to get it to build. I wonder if it would be possible to simplify the dependencies by asking ahead of time of the libraries are present via ocamlfind query sqlite3 (or similar).

I think that trakeva_of_uri should only be built if both the sqlite and postgres versions are built.

smondet commented 9 years ago

I'm happy to let opam decide wether to build the optional libraries or not.

The point of trakeva_of_uri is to be able to use trakeva without forcing dependencies on one or another. in the branch https://github.com/hammerlab/ketrew/tree/pluggable-db you can now build Ketrew with sqlite or postgresql or both (or none, but then it just fails because for Ketrew the DB is not optional).