search

smoope / SwiftyTraverson

Other
7 stars 3 forks source link

Gerson silva filho - Adding support to "links" instead of "_links". #6

Open GersonSilvaFilho opened 7 years ago

vicmosin commented 7 years ago

Hi @GersonSilvaFilho , many thanks for your PR but I believe this change is too private case and can be solved as a resolver extension in your local project.. HAL standard clearly defined the _links property.

GersonSilvaFilho commented 7 years ago

Hi @vicmosin

Thanks for your reply =)

Yes at first i thought this was something really specific, that's why i added the name "TraversonModifiedJsonHalLinkResolver". Now i've found out that there is an specific protocol called Siren that follow same principles than HAL and don't use the underscore.

https://github.com/kevinswiber/siren

Actually the API that i'm using is following this pattern. Do you think that would be good to add it? I would correct the names to "TraversonSirenLinkResolver" and ".Siren"or something like that.

vicmosin commented 7 years ago

Sure. But please provide appropriate tests