smooth-code / bundle-analyzer

Keep your webpack bundle optimized over time 📦✨
https://www.bundle-analyzer.com
GNU General Public License v3.0
96 stars 4 forks source link

Github check does not appear #16

Open skjnldsv opened 5 years ago

skjnldsv commented 5 years ago

Hey!

Thanks for your awesome app, looks very promising! https://github.com/skjnldsv/vueexample/pull/237/checks

Just enabled this, and I can see the results just fine https://app.bundle-analyzer.com/gh/skjnldsv/vueexample But there is no github checks on my pull requests. Anything I need to do?

gregberge commented 5 years ago

Everything fine, just make a new pull-request and it should show up.

skjnldsv commented 5 years ago

I did already, it doesn't :) https://github.com/skjnldsv/vueexample/pull/261

skjnldsv commented 5 years ago

@neoziro My guess is the bundle analyzer don't understand it comes from a pull request against master and not a merge. The result on https://app.bundle-analyzer.com/gh/skjnldsv/vueexample/builds/8 show the branch is master, but it's not.

Capture d’écran_2019-10-02_12-42-34 Capture d’écran_2019-10-02_12-42-40

skjnldsv commented 5 years ago

Reopen? :)

gregberge commented 5 years ago

Hello @skjnldsv, so what is the problem exactly? Let's fix it!

skjnldsv commented 5 years ago

When opening a new pr, there is no GitHub checks for me :/ Do I need to configure something more? :)

Also it looks like all pr are displayed as master commits instead of the current branch of the commit (see previous comment)

ChristophWurst commented 5 years ago

If I go to https://app.bundle-analyzer.com/gh/nextcloud/mail/builds I see only builds on master, though most are from PRs. Same wrong info at https://app.bundle-analyzer.com/gh/nextcloud/mail/builds/358

Branch master

Do we miss any configuration? How's the branch determined?

ChristophWurst commented 4 years ago

Is it maybe because we use an organization? @gregberge have you tested with such a repo?

gotbahn commented 4 years ago

Hey guys, same happens for us. I'm trying to integrate your solution into our organisation. But GitHub checks is stale in waiting status despite finished job.

image

image