search

smouksassi / ggquickeda

ggplot2 and table1 summary statistics quick exploration of data
https://smouksassi.github.io/ggquickeda/
Other
71 stars 8 forks source link

Deal with non-CRAN dependencies `ggkm` #4

Closed daattali closed 6 years ago

daattali commented 6 years ago

Currently both ggkm and table1 are only offered as github packages, so they are mentioned in the DESCRIPITON file as remote packages. This is fine for now but it means that ggquickeda can only be installed as a github package, not on CRAN. To get to CRAN, all dependencies must be on CRAN.

smouksassi commented 6 years ago

@sachsmc would you like to make a PR to push the ggkm part into the repo ?

smouksassi commented 6 years ago

@benjaminrich do you plan to publish table1 into CRAN anytime soon ? Alternatively we can include the relevant part into ggquickeda

daattali commented 6 years ago

@sachsmc said we can include the ggkm code in a separate file within the app

daattali commented 6 years ago

@smouksassi I've added both ggkm and table1 code into the package source code. If table1 ever gets on CRAN we can revisit. Can we close this issue or do we want to wait for table1 to be on CRAN?

smouksassi commented 6 years ago

now that table1 is on CRAN we need to use the funnctios from table1 and deprecate the one from ggquickeda for the html tables. as for ggkm it will stay part of ggquickeda as per @sachsmc preference.

daattali commented 6 years ago

dependency on table1 has been removed

daattali commented 6 years ago

If there's no plan on ever putting ggkm on CRAN, this issue can be closed