search

smourier / DirectN

Direct interop Code for .NET Framework, .NET Core and .NET 5+ : DXGI, WIC, DirectX 9 to 12, Direct2D, Direct Write, Direct Composition, Media Foundation, WASAPI, CodecAPI, GDI, Spatial Audio, DVD, Windows Media Player, UWP DXInterop, WinUI3, etc.
MIT License
311 stars 28 forks source link

MFCreateSourceReaderFromMediaSource function signature seems incorrect. #24

Closed Steph55 closed 2 years ago

Steph55 commented 2 years ago

Thank you very much for the last corrections, it is much better now! Here I have another one which appears to me as being wrong:

MFCreateSourceReaderFromMediaSource:

C++ STDAPI MFCreateSourceReaderFromMediaSource( _In_ IMFMediaSource *pMediaSource, _In_opt_ IMFAttributes *pAttributes, _Out_ IMFSourceReader **ppSourceReader );

C# [DllImport("mfreadwrite", ExactSpelling = true)] public static extern HRESULT MFCreateSourceReaderFromMediaSource(/* _In_ */ ref int pMediaSource, /* _In_opt_ */ IMFAttributes pAttributes, /* _Out_ */ out IMFSourceReader ppSourceReader);

The first parameter types seem to be incompatible !

smourier commented 2 years ago

True! I've fixed it. Thanks.