smpallen99 / coherence

Coherence is a full featured, configurable authentication system for Phoenix
MIT License
1.27k stars 225 forks source link

Refactor Coherence to better align with Phoenix idioms #187

Open smpallen99 opened 7 years ago

smpallen99 commented 7 years ago

I believe there are a number of things that we should refactor in Coherence to better align with Phoenix design. This issue is collect and review ideas from the community.

I look forward to your feedback and suggestions.

Here are some ideas I've been thinking about:

smpallen99 commented 7 years ago

After reviewing Plug.Session based on #52, I've decided that having Coherence plugs implement the Plug.Session.Store behaviour would be a great improvement. This way, it should be trivial to add additional session stores like redis, memcahed, etc.

Consider this part of the roadmap.

agustif commented 7 years ago

This looks awesome @smpallen99 , thanks for taking the time into making coherence better, I've been following the repo the last months !! Hope new phx stuff brings modularity and not just madness hahaha!