smpallen99 / coherence

Coherence is a full featured, configurable authentication system for Phoenix
MIT License
1.27k stars 224 forks source link

Remember me functionality parses parameter incorrectly #370

Closed romikoops closed 6 years ago

romikoops commented 6 years ago

I have observed Remember me works all time, even if Remember me checkbox is not set. After exploring implementation, I have found it does not convert parameter from string to boolean here https://github.com/smpallen99/coherence/blob/master/lib/coherence/controllers/session_controller.ex#L81 As result any value, like "", "true", "false" will be parsed as TRUE. Either I missed something with my configuration or it is real bug. Now I have patched it with custom plug but it will be nice to fix it.

smpallen99 commented 6 years ago

Confirmed. This is a bug.