search

smpallen99 / coherence

Coherence is a full featured, configurable authentication system for Phoenix
MIT License
1.27k stars 224 forks source link

Redirect not working for 'registration_create' #372

Open pradosh987 opened 6 years ago

pradosh987 commented 6 years ago

Redirect for registration_create not working after updating 0.5.0 to 0.5.2. password_create is working in new version

jung-hunsoo commented 5 years ago

I'm getting the same issue.

It was working on v0.5.0, but the same redirect function doesn't be called in v0.5.2 while session_create can be override.

It's suspect that the coherence/lib/coherence/controllers/registration_controller.ex has a problem (not sure).

romikoops commented 5 years ago

Does not work for me too

romikoops commented 5 years ago

I guess I found the bug.

https://github.com/smpallen99/coherence/blob/master/lib/coherence/responders/html.ex#L56

should be :registration_create instead of :session_create

But, keep in mind, if Config.allow_unconfirmed_access_for = 1, then it will be never triggered. In that case you have to use session_create callback, cause next step after registration is login