search

smpallen99 / ex_admin

ExAdmin is an auto administration package for Elixir and the Phoenix Framework
MIT License
1.2k stars 275 forks source link

Fixing issues reported by hex audit (updating all hex packages automa… #453

Closed vraravam closed 1 year ago

vraravam commented 5 years ago

…tically).

Fixes #451

happysalada commented 5 years ago

updating xain to the latest version, breaks everything. You can't edit anymore, all links show up as escaped markup language. (I'm not a maintainer nor a contributor, just letting you know)

vraravam commented 5 years ago

thanks @happysalada - i'm not sure how to fix those - since the CI builds have been broken for quite some time now. I guess we have to take a closer look at latest xain - most likely the issue is there?

happysalada commented 5 years ago

so the update on xain was a security update. I'm not sure, how exactly xain is used here, but most likely usage here needs to be updated.

On another note, this repo hasn't been active for more than 6 months. The owner is likely busy with other stuff now and not accepting any new maintainers. I would say that unfortunately no PR is ever going to be accepted (even if we fix the xain issue). There is currently 270 forks of this project, but nobody really taking the lead in trying to replace this existing repo.

I would say your best bet, is to wait that the owner comes back or that a fork of this project takes the lead in fixing all the issues.

If your project is working fine right now, just don't update I would say. (unfortunately)

susana-garcia commented 5 years ago

We did some internal fixes to get ExAdmin to work with the newest version of xain. There's still a lot of problems and most of it is untested, but it'll be a good starting point:

https://github.com/smpallen99/ex_admin/commit/569b8497bd1e9dbf2ca7d04ff52d5299dd3ce094

susana-garcia commented 5 years ago

PS: This is caused by https://github.com/smpallen99/ex_admin/issues/451

vraravam commented 5 years ago

I'm thinking of forking this codebase, reverting back to the last known green build and continuing from there. Since the license is MIT, I don't think there would be any licensing issues.

I would welcome at least 2-3 others who can form part of the core group of volunteers to ensure that the same state of affairs is not repeated.

I actually love ex_admin and would like to call out a special thanks to @smpallen99 for writing this package. (I'm thinking of calling the new project as phoenix_admin

Preen commented 5 years ago

We are about to release a new admin soon. Will let you know once we have it in public.

vraravam commented 5 years ago

@Preen - any ETA? or is the repo something we can look at right now? Will it be OSS?

Preen commented 5 years ago

@vraravam https://github.com/FLEWID-AB/alkemist

We have released the Beta to the public now. The documentation is somewhat lacking but we thought it would be better to release it now than wait.

vraravam commented 5 years ago

@Preen - AWESOME! I was creating a starter project for phoenix 1.4 just this past weekend - I will incorporate alkemist into that and take it for a spin!

Preen commented 5 years ago

@vraravam Awesome!!! :)