search

smpallen99 / whatwasit

Track changes to your Ecto models
MIT License
63 stars 8 forks source link

Fork: Refactor and simplify code #17

Closed Eiji7 closed 8 years ago

Eiji7 commented 8 years ago

TODO:

  1. Better code configuration
  2. Better code modularization
  3. No code duplication
  4. No code generation (by templates)
  5. Remove install task
smpallen99 commented 8 years ago

@Eiji7 Thanks for taking this on!!

Few requests...

Eiji7 commented 8 years ago
  1. Ok. I will update this and provide more info in separeted issues in next days.
  2. My code should me much more configurable than you (at now I have 33 config variables), so don't worry about this :-). Of course any tips are welcome.

First commit should be uploaded in this or next week.

Eiji7 commented 8 years ago

@smpallen99: Hmmm, I have a problem with relations. I have good code (only initial work now ie. relations only). It already works except preload. I want to solve this by relations, because I think it's more "ecto like". I need a prefix, because I don't want to conflict with data in project database (for example: Redmine is in RoR, but they have "projects" and "versions" tables ie. project versions, so It is possible that someone cannot deploy app with this dependency, because tables conflict). More info (and initial commit) I provide directly after solve this isssue and test my code in IEx (insert to example table, insert version for it and preload with versions). Edit: this topic is solved. I need write a custom preload method, because Ecto support for prefix is really poor. Now I have a way to complete this. In this week I will push first commit with logging and initial work for differ at same time.

Eiji7 commented 8 years ago

Ok, I started some things (initial work) see my project page. I need to add implementation to all TODO comments + implement things from my issues + documentation + new tests. More info I provide tomorrow. I created the code from scratch, so they can be there still shortcomings (eg. unnecessary mix dependencies). Any tips are welcome 😄.

Eiji7 commented 8 years ago

@smpallen99: I want you commented on my changes before my further work, because there is no need to change the same code fragments several times..

Eiji7 commented 8 years ago

@smpallen99: Still no response ... I will continue in next week (ie. two weeks after initial commit) without waiting for you. After next two weeks (and no response from you) I will create my new project from my last commit in this project. I know you are very busy, but I can't wait any longer for approve my changes by you.

smpallen99 commented 8 years ago

@Eiji7 Sorry for the delay getting back to you. I'll take a look in the next couple days.

Steve

Eiji7 commented 8 years ago

@smpallen99: uff, you find some time for this project, thanks 😄

smpallen99 commented 8 years ago

@Eiji7 I took a quick look at your branch. Give that your using different different base name and non-standard elixir source indentation, I think its best that you create your own package. I just ask that you use a different and distinct name for your package.

Eiji7 commented 8 years ago
  1. "non-standard elixir source indentation"
    I use "elastic tabs"
    It's not a problem to replace all "\t" to " " and push it as a "fix".
  2. "Give that your using different different base name"
    Sorry for that. I generated some code like: "what_was_it" (by mix phoenix.new) intead of "whatwasit" and then copy it to my code and finally modify it. Also one replace can fix that.

I mean something else. I asked about ways to solve some things. For example my config implementation (instead of generating code from template) or using protocol for diffs. I want to got comment about how code works (not how it looks). See, this is my first real project code.

Edit: Your answers appear too late, so good cooperation is not possible. I decided to create a new project with a new name which I will choose.