search

smplayer-dev / smplayer

Free Media Player for Windows, Linux and Mac OS with YouTube support.
https://smplayer.info
GNU General Public License v2.0
689 stars 93 forks source link

Add option to limit the number of files with remembered settings #181

Open anewuser opened 3 years ago

anewuser commented 3 years ago

I've found out my smplayer_files.ini file has almost 200.000 lines.

I expected the Interface → Privacy setting to limit the amount of entries in the smplayer_files.ini file too, since it's pointless to keep playback information for all videos I've ever watched.

smplayer 21.8.0 Windows 10

smplayer-dev commented 3 years ago

You can use the option "store settings in multiple ini files" in preferences -> general, so instead of a one big ini file it will use a ini file for each video.

anewuser commented 3 years ago

But then it will create an unlimited number of files, right?

smplayer-dev commented 3 years ago

Yes.

anewuser commented 3 years ago

This feature is useful for when you have to stop different files before getting back to then hours or maybe days later, but I don't think anyone wants the player to permanently keep a list of all files they finished watching and deleted several months or even years ago.

What about moving these files to the operating system temp folder? That way, you won't have to work on any logic to limit them or check their dates.

EliEron commented 3 years ago

I heavily disagree. The fact that SMPlayer remembers files forever is precisely why I started using it in the first place. And it's important to note that it does not just store the play time but tons of other information about what you changed while watching the file (Rotation, A/V sync, Zoom, etc) which are things that can be very useful to retain even years later. And the total cost of this is ~2kb per file remembered, so storage waste is not a remotely realistic concern.

I would not oppose an option being added (as I think the more customizable something is the better) but it should not be tied to the existing privacy options. Doing that would create havoc for all the users who actually maintain a permanent media collection on their machine. And while that might not be the norm, it is exactly the type of user that would be attracted to a third-party media player like SMPlayer.

Also I realize this is a pretty old issue, so commenting is somewhat pointless. I'm only expressing my opinion in case somebody ever decided to follow up on it. As I feel pretty strongly on this issue.

anewuser commented 3 years ago

Nobody has expressed concerns with storage waste. My idea was just to protect people's privacy.

You could've just summarized your whole comment with, "I actually find the current behavior useful. If you implement this idea, please make it optional."

EliEron commented 3 years ago

That is indeed an accurate summary of my comment. Succinctness has never been my strong suit, especially when it comes to topics I care deeply about.

And I only brought up storage waste because I genuinely thought that was your main concern based on the comments you made, if that was not your intent then I apologize for bringing that up.

goyalyashpal commented 2 years ago

Succinctness has never been my strong suit, especially when it comes to topics I care deeply about.

umh, succinctness is very important when dealing wih software devt and issue filing related to it. although, i agree that overexplanation comes when there is some kind of implicit fear involved of the other side not listening you enough or not understanding you. anyways, it's okay.

anewuser commented 2 years ago

As a temporary workaround, I've created symlinks from playlist.ini and smplayer_files.ini to a folder in a RAM disk that gets erased when I restart or shut down my computer.