smplayer non native file dialog - limousine bug😅

[goyalyashpal]

note: file dialog here means non-native file dialog unless stated otherwise

Summary of the bug

file dialog is super stretched

Describe the bug

the non-native file dialog in "choose file mode":

• is super stretched and cannot be shrunk
• sometimes when this dialog is open, and u click outside smplayer window, it becomes invisible but is still blocking the smplayer main window. so, it (the file dialog) has to be exited out of using esc

To Reproduce

note: here, i am using:

• * for indicating that previous key has to be hold pressed
• > to indicate "then", i.e. press previous key once and leave, and "then" press the next key
• ^ to mean ctrl

Steps to reproduce the behavior:

1. "preferences" ^p > interface : interface > use the system native file dialog : disabled > apply > ok
2. "open > directory" i.e. alt * ( o > i ) to verify that issue doesn't manifest itself here
3. press esc
4. "open > file" ^f i.e. alt * ( o > f ) to experience the issue
5. click on the left boundary of the file dialog, or maybe left outside of the smplayer main window and it will disappear. [the second issue]

Expected behavior

the file dialog shouldn't be that stretched

Screenshots

If applicable, add screenshots to help explain your problem.

• Issue 2: file dialog disappearing: (the keypress overlay doesn't show escape i think)

https://user-images.githubusercontent.com/19423063/185733042-2feaf342-b98c-42cd-8bf5-b20cd90f51fa.mp4

• issue 1: wide

https://user-images.githubusercontent.com/19423063/185733120-41e747f1-38e9-40a3-8061-13ea5c3ffefe.mp4

Your Enviroment

• OS: Windows 10 20H2
• SMPlayer version: Version: 22.7.0 (revision 10091) (64-bit) Using MPV 0.34.0 Using Qt 5.15.2 (compiled with Qt 5.15.2)

Logs

Reproduce the bug in your computer and attach the smplayer log (menu View) here.

[goyalyashpal]

Additional context

Add any other context about the problem here.

observations:

• the file dialog's width is restricted to some minimum, beyond which it can't be shrunk further
• the "files of type" drop down list in the "choose a file" mode contain super long enteries which are not truncated
• the "files of type" drop down list is one of factors determining the min-width of the file dialog
• the min-width of that drop down list stays capped by the longest item in that list so, doesn't matter if u switch to say "all files (*.*)" , the min-width will still say the same
• so, when the file dialog is opened in "choose a file" mode, it shows the behaviour mentioned in this issue

Suggested fixes

if my observations above regarding "files of type" list being the culprit is correct, then:

• the item display in that list should be made

  • truncated
  • umh, i guess it's called reflowable? i.e. truncating depending on width

• optionally: if info regarding full list is desired to be displayed, then inspiration can be took from the native file dialog where:

  • hovering on the list display shows an expanded tooltip which spans multiple lines if needed

https://user-images.githubusercontent.com/19423063/185732902-2d3f4282-742f-44c3-bfcb-92ec0e0022c7.mp4

[goyalyashpal]

@smplayer-dev ping

[goyalyashpal]

issue still exists:

Version: 23.12.0 (revision 10207) (64-bit)
Portable Edition
Using Qt 5.15.2 (compiled with Qt 5.15.2)
Using MPV 0.36.0