Open DaviMedrade opened 1 year ago
Additionally, the mpv documentation says that nvdec
and nvdec-copy
are the recommended settings for NVIDIA GPUs, and also that using cuda
and cuda-copy
may cause problems. By selecting Auto
, nvdec
is used by mpv in my system, but NVIDIA users are still lacking important options in the hardware decoding list.
Quote from mpv documenation:
nvdec
andnvdec-copy
are the newest, and recommended method to do hardware decoding on Nvidia GPUs.
cuda
andcuda-copy
are an older implementation of hardware decoding on Nvidia GPUs that uses Nvidia's bitstream parsers rather than FFmpeg's. This can lead to feature deficiencies, such as incorrect playback of HDR content, andnvdec
/nvdec-copy
should always be preferred unless you specifically need Nvidia's deinterlacing algorithms.
I've just updated the list in this commit https://github.com/smplayer-dev/smplayer/commit/a2506f7238994971848db67844ea0d8ec9ee70da
Describe the bug The list of hardware decoders in the Performance options doesn't show
nvdec
nornvdec-copy
, which are valid decoders formpv
.To Reproduce Steps to reproduce the behavior:
nvdec
nornvdec-copy
.Expected behavior From mplayeroptions.cpp I understand that the “Hardware Decoding” option is only supported by
mpv
. Ideally, all hardware decoders supported by the runningmpv
, and only those, would be displayed. The list can be obtained by runningmpv --hwdec=help
.From what I can tell by the source in prefperformance.cpp, the hardware decoder list is hard-coded, with some compile-time toggles by OS (and one run-time check for Windows version). But there's no guarantee that those hardware decoders have been compiled into
mpv
, and new decoders added tompv
would have to be manually added to this list.My suggestion is that the list of hardware decoders is initialized from the results of running
mpv --hwdec=help
, which would ensure that only the decoders that are supported by the running platform and have been compiled intompv
are presented as options.Alternatively, or in the interim, the options
nvdec
andnvdec-copy
should be added (at least for Linux; I don't know if they are supported bympv
in Windows or OSX).Your Enviroment