smplayer-dev / smplayer

Free Media Player for Windows, Linux and Mac OS with YouTube support.
https://smplayer.info
GNU General Public License v2.0
689 stars 93 forks source link

Volume control multimedia keys binding should be removed #844

Open JasonSpine opened 1 year ago

JasonSpine commented 1 year ago

Describe the bug Volume control multimedia keys change volume of SMPlayer and volume of the operating system.

To Reproduce Steps to reproduce the behavior:

  1. Run a movie.
  2. Use volume control multimedia keys (Vol Up, Vol Down).

Expected behavior SMPlayer volume shouldn't be affected. Only system volume should be affected. SMPlayer volume should use different key bindings by default.

Your Enviroment

bob860712 commented 11 months ago

Go to Options->Preferences->Keyboard and mouse->Keyboard Disable Use multimedia keys as global shortcuts or enable it and click Select keys, disable Volume Up and Volume Down there.

That should work. If not, find volume - and volume + in Options->Preferences->Keyboard and mouse->Keyboard and change the shortcut key.

JasonSpine commented 11 months ago

I know I can change shortucut keys. I did it.

But I think that next SMPlayer builds by default shouldn't use multimedia keys, because they are used by operating systems. VLC doesn't use volume keys and that's what SMPlayer should do too.

smplayer-dev commented 11 months ago

As far as I know the multimedia keys are already disabled by default, aren't they?

JasonSpine commented 11 months ago

Since when? I've installed smplayer-23.6.0-win32-qt5.6-unsigned.exe last month on fresh Windows 11 PC, so there was no existing configuration on this device.

I'm not taking about global shortcuts checkbox - because it affects only SMPlayer running in background. I don't want multimedia keys to work in SMPlayer while watching the movie, because they are used by operating system now. Volume keys need to be removed from default shortcuts binding.

obraz

Default binding of multimedia keys in video players apps made sense in the past, when operating systems didn't use multimedia keys. Now it has to be updated.