smplayer-dev / smplayer

Free Media Player for Windows, Linux and Mac OS with YouTube support.
https://smplayer.info
GNU General Public License v2.0
685 stars 94 forks source link

Subtitle: TTML support #920

Open 3052 opened 8 months ago

3052 commented 8 months ago

I have the below file, the subtitles load but are not displayed

Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'out.mp4':
  Metadata:
    major_brand     : isom
    minor_version   : 512
    compatible_brands: isomiso2avc1mp41
    encoder         : Lavf60.16.100
  Duration: 01:38:48.75, start: 0.000000, bitrate: 3957 kb/s
  Stream #0:0[0x1](und): Video: h264 (Main) (avc1 / 0x31637661), yuv420p(progressive), 1200x720 [SAR 1:1 DAR 5:3], 3822 kb/s, 24 fps, 24 tbr, 19200 tbn (default)
    Metadata:
      handler_name    : USP Video Handler
      vendor_id       : [0][0][0][0]
      encoder         : AVC Coding
  Stream #0:1[0x2](zho): Audio: aac (LC) (mp4a / 0x6134706D), 48000 Hz, stereo, fltp, 127 kb/s (default)
    Metadata:
      handler_name    : USP Sound Handler
      vendor_id       : [0][0][0][0]
  Stream #0:2[0x3](eng): Subtitle: ttml (stpp / 0x70707473), 1 kb/s (default)
    Metadata:
      handler_name    : USP Subtitle Handler
smplayer-dev commented 8 months ago

Could you send a sample?

3052 commented 8 months ago

https://github.com/smplayer-dev/smplayer/files/14589709/af343964d7-textstream_eng.1000.zip

smplayer-dev commented 8 months ago

It doesn't seem supported by mpv:

No sub streams in file af343964d7-textstream_eng=1000.mp4.
Can not open external file af343964d7-textstream_eng=1000.mp4.
3052 commented 8 months ago

are you saying that SmPlayer is just a front end for MPV?

smplayer-dev commented 8 months ago

Yes.

3052 commented 8 months ago

is that documented? I don't see a single mention of MPV here:

https://github.com/smplayer-dev/smplayer

smplayer-dev commented 8 months ago

The website mentions it https://www.smplayer.info It's also in the about dialog.

3052 commented 8 months ago

The website mentions it https://www.smplayer.info/

uh, where? I just checked and I dont see a single mention of it

smplayer-dev commented 8 months ago

"Now SMPlayer supports mpv as well" which links to https://www.smplayer.info/en/mpv

3052 commented 8 months ago

I think it should be WAY more obvious that SmPlayer is just a frontend for MPV. that info should be included on one or both of these pages:

https://github.com/smplayer-dev/smplayer https://www.smplayer.info

adalbosco commented 3 months ago

I think it should be WAY more obvious that SmPlayer is just a frontend for MPV. that info should be included on one or both of these pages:

https://github.com/smplayer-dev/smplayer https://www.smplayer.info

You probably feel that way because you don't know SMPlayer long enough. MPV is a branch/successor of "mplayer", which SMPlayer was a front-end for (and afaik SMPlayer still supports mplayer as backend instead of mpv). There were other frontends with similar names like KMPlayer, for example. You don't need to write a note anywhere when the name of the software itself indicates that it's a frontend to a widely known command line player.

3052 commented 3 months ago

You don't need to write a note anywhere when the name of the software itself indicates that it's a frontend to a widely known command line player.

idiotic comment. the name of the software is SmPlayer, nothing about that indicates an association wth MPV, unless you already know the history.

just because you know the full lineage of SmPlayer, doesnt mean anyone else does, nor should they.