smr547 / meeting_minutes

Create meeting agendas and minutes based on GitHub Issues
GNU General Public License v3.0
0 stars 1 forks source link

Google Java formatting does not work with current Gradle version #4

Open smr547 opened 1 year ago

smr547 commented 1 year ago

I got the build to work by disabling the Google Java Formatting plugin in the build.gradle file.

@sjamesr may be interested

sjamesr commented 1 year ago

This is a patch on top of 42e2a77ace9d9a549f14b5ee9f30b05d3a3eb56f.

After applying this, run ./gradlew wrapper, ./gradlew googleJavaFormat. Should work with Java 17.

diff --git a/build.gradle b/build.gradle
index 9efef31..d4346dc 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,13 +1,13 @@
 plugins {
   id 'application'

-  id 'com.github.sherter.google-java-format' version '0.3.2'
+  id 'com.github.sherter.google-java-format' version '0.9'
 }

 mainClassName = 'au.com.southsky.minutes.Main'

 wrapper {
-  gradleVersion = '6.6.1'
+  gradleVersion = '7.6.3'
 }

 repositories {
@@ -15,16 +15,20 @@ repositories {
 }

 dependencies {
-  compile group: 'com.beust', name: 'jcommander', version: '1.78'
-  compile group: 'org.kohsuke', name: 'github-api', version: '1.116'
-  compile group: 'com.itextpdf', name: 'itext7-core', version: '7.1.9'
-  compile group: 'com.itextpdf', name: 'html2pdf', version: '2.1.6'
+  implementation group: 'com.beust', name: 'jcommander', version: '1.78'
+  implementation group: 'org.kohsuke', name: 'github-api', version: '1.116'
+  implementation group: 'com.itextpdf', name: 'itext7-core', version: '7.1.9'
+  implementation group: 'com.itextpdf', name: 'html2pdf', version: '2.1.6'

-  compile group: 'com.atlassian.commonmark', name: 'commonmark', version: '0.15.2'
+  implementation group: 'com.atlassian.commonmark', name: 'commonmark', version: '0.15.2'

-  compile group: 'org.slf4j', name: 'slf4j-api', version: '1.7.22'
-  compile group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.13.3'
-  compile group: 'org.apache.logging.log4j', name: 'log4j-slf4j-impl', version: '2.13.3'
+  implementation group: 'org.slf4j', name: 'slf4j-api', version: '1.7.22'
+  implementation group: 'org.apache.logging.log4j', name: 'log4j-core', version: '2.13.3'
+  implementation group: 'org.apache.logging.log4j', name: 'log4j-slf4j-impl', version: '2.13.3'
+}
+
+googleJavaFormat {
+  toolVersion = '1.2'
 }

 // If Java formatter checks fail, tell the user how to fix them.