Closed hemberger closed 3 months ago
Attention: Patch coverage is 83.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 30.86%. Comparing base (
0469ddf
) to head (5a88818
).
Files | Patch % | Lines |
---|---|---|
src/lib/Smr/AbstractPlayer.php | 0.00% | 1 Missing :warning: |
src/lib/Smr/Planet.php | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Special handling needed for the following BC break:
Basically, this means that we can't call call
Database::getInsertID
on arbitrary INSERT/REPLACE statements, because they would throw if they don't have an auto-increment column.Add separate methods
{replace,insert}AutoIncrement
, which are called explicitly when we need to know the updated column(s).