search

smsapi / smsapi-csharp-client

SMSAPI C# client that allows you to send messages and administrate your SMSAPI account.
https://www.smsapi.com/
29 stars 20 forks source link

SMSApi.Api.Exception has name the same as System.Exception. This may cost a lot of time to find what is going on #40

Open owerkop opened 5 months ago

owerkop commented 5 months ago

We have in our code:

try {
...
}
catch (Exception e)
{
...
}

It didn't work. It turned out the Exception was from SMSApi.Api namespace instead of System.

I think this is really unexpected to have library having public Exception class.

mpawikowski commented 5 months ago

Hello,

I forwarded it to our IT department.

jakublabno commented 5 months ago

Hello, please let us know about version used, please also send imports you have in your class.

jakublabno commented 5 months ago

Thank you for the report, we will change name/access or make further refactor to get rid of this in 3.x.x version (https://github.com/smsapi/smsapi-csharp-client/tree/3.x.x-dev) .