smsapi / smsapi-php-client

SMSAPI PHP client that allows you to send messages, manage Short URLs and administrate your SMSAPI account.
https://www.smsapi.pl
Other
64 stars 39 forks source link

Is php 7.4.3 issue. #133

Open bubolski opened 1 month ago

bubolski commented 1 month ago

I cannot run this because composer require php >= 8.0

Looks like psr/log requierd minimum php 8.0

Is there a workaround to make it work?

maciejlew commented 1 month ago

Library latest version (3.0.11) has been tested against PHP 7.4. You can check it here: https://github.com/smsapi/smsapi-php-client/actions/runs/8449448350/job/23143544970 (logs are no longed available but the job was marked green).

You can run that test on you own, execute make test-suite-php-7.4 SUITE=unit from build directory.

Output should look like this one:

docker-compose run -T php-7.4 /usr/bin/composer update
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
24 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
docker-compose run -T php-7.4 php vendor/bin/phpunit --configuration tests-resources/phpunit.xml --testsuite unit
PHPUnit 8.5.39 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.29 with Xdebug 2.9.8
Configuration: /app/tests-resources/phpunit.xml

................................................................. 65 / 95 ( 68%)
..............................                                    95 / 95 (100%)

Time: 117 ms, Memory: 10.00 MB

OK (95 tests, 188 assertions)

It runs against PHP 7.4.29, not 7.4.3, however that should not matter. Checkout build/php-7.4/Dockerfile.