Support for Guzzle 7 - Githubissues

smsapi / smsapi-php-client

SMSAPI PHP client that allows you to send messages, manage Short URLs and administrate your SMSAPI account.

https://www.smsapi.pl

Other

64 stars 39 forks source link

Support for Guzzle 7 #90

Closed snapshotpl closed 3 years ago

snapshotpl commented 4 years ago

This PR introduce support for Guzzle 7. However I can't keep compatibility with Guzzle 6 because GuzzleClientLoggerDecorator relay on ClientInterface which changed API beetween 6 and 7. It's possible to keep compatibility by extract GuzzleClientLoggerDecorator to external lib, but question is: are we really need support for v6?

maciejlew commented 4 years ago

Thanks for your input but we cannot merge that. There are clients who still use PHP 7.0. That pull request would break backward compatibility. However we are aware of that problem. To solve it, we are going to take use of PSR-18 with our next major release.

danijelk commented 3 years ago

Why not just release it as a v3? That's how all other packages maintain compatibility with new upgrades?

snapshotpl commented 3 years ago

That's a good question

danijelk commented 3 years ago

@maciejlew please come with a reply, or we'll have to look at changing provider to move forward with our environment. thanks!

smsapi commented 3 years ago

Hi @danijelk we will take care of this case as soon as possible. We will keep you updated. For now you can use version of our library modified by you.

danijelk commented 3 years ago

Any ETA on it? We have to inform our customers when we will have an update available.

We are not running our own version, that's @snapshotpl :)

snapshotpl commented 3 years ago

Currently I use my fork on production but still waiting for official release

smsapi commented 3 years ago

@danijelk we will try to add it until end of 2020.