search

smsapi / smsapi-python-client

SMSAPI Python client that allows you to send messages, manage Short URLs and administrate your SMSAPI account.
https://www.smsapi.com/
Other
55 stars 34 forks source link

make SMSAPI exceptions pickleable #28

Closed skarzi closed 3 years ago

skarzi commented 3 years ago

Hi :wave:

First of all thanks for the great API and its python client! Recently, I have started using celery to send SMS messages via SMSAPI and I discovered that it's impossible to store information about SMSAPI exceptions using celery result backends because SMSAPI exceptions are not pickleable.

In this PR I have added tests for SMSAPI exceptions pickling and made SMSAPI exceptions pickleable.

in-void commented 3 years ago

Hi. Thanks for the commits. However It looks like this change breaks the 2.7 unit tests: https://travis-ci.org/github/smsapi/smsapi-python-client/jobs/761960096

skarzi commented 3 years ago

You have linked the build run of PR #27. However, it's true that this PR is not fully compatible with python 2.7, because of unittest.TestCast.subTest usage - https://travis-ci.org/github/smsapi/smsapi-python-client/jobs/761960096

I will fix it in the next commit

skarzi commented 3 years ago

@in-void when we can expect a new package release to PyPI?

in-void commented 3 years ago

@skarzi I will be bumping version later today