search

smsohan / MvcMailer

A Mailer for ASP.Net MVC that forms the Email Body using MVC Views (Razor etc.) following Ruby on Rails ActionMailer style
MIT License
585 stars 176 forks source link

NuSpec with a dependency on VS2013's Scaffolder - Fixes #116 #123

Closed shanselman closed 10 years ago

shanselman commented 10 years ago

Fixes #116

Scaffolding in 2013 is changing (and has changed) and won't be supported. However, there is a vs2013 version of the T4Scaffolder and this package depends on it.

Good news - This seems to work fine under VS3013 when the IDE is run as Admin. Bad news - Because this NuGet will have a dependency on a -pre (prelease) package, then it becomes prerelease. That means there are TWO packages. MvcMailer and MvcMailer-vs2013.

http://docs.nuget.org/docs/reference/versioning#Prerelease_Versions

That means, you would install it like this:

install-package MvcMailer-vs2013 -pre

Which in turn brings in the T4 pre dependency.

NOTE: I didn't mess with the rake file OR the publish. A NuPkg will get make when you run rake as the work happens in CSProj (looks like the rakefile was never completed to support NuGet?)

NOTE 2: I had to update NuGet.exe to latest.

TODO: You'll want to publish the new package as it's down thing (and perhaps advertise that it exists by mentioning it in the EXISTING version's NuGet package as well as in the Readme.md? I added that also, if that's OK.

smsohan commented 10 years ago

@shanselman thanks for this. I really appreciate it. I've created a new branch for vs2013, please open a PR against that branch. That way we can keep the master as is while release a new version for 2013. Will trigger a build tonight.

smsohan commented 10 years ago

Here's the branch https://github.com/smsohan/MvcMailer/tree/MvcMailer-vs2013

smsohan commented 10 years ago

closing in favor of https://github.com/smsohan/MvcMailer/pull/125

shanselman commented 10 years ago

With all due respect, there's no need for a new branch. Take a look at the changes that I made. This all builds from the same source.

I didn't change anything I only added a new build artifact.

On Feb 11, 2014, at 10:31 PM, SM Sohan notifications@github.com wrote:

@shanselman thanks for this. I really appreciate it. I've created a new branch for vs2013, please open a PR against that branch. That way we can keep the master as is while release a new version for 2013. Will trigger a build tonight.

— Reply to this email directly or view it on GitHub.