search

smsohan / MvcMailer

A Mailer for ASP.Net MVC that forms the Email Body using MVC Views (Razor etc.) following Ruby on Rails ActionMailer style
MIT License
582 stars 178 forks source link

Fix: extension method "Abs" outputs malformed URLs #15

Closed jamestelfer closed 13 years ago

jamestelfer commented 13 years ago

Use "AbsoluteUri" instead of "ToString()" to avoid removing the escaping from query string parameters.

This means that a URL like "/page.html?query=parameter%20value" will be output with the %20 intact, rather than using a space.

Thanks for the great package, a joy to use :)

smsohan commented 13 years ago

Thanks for pointing this to me. I will include this in the next release.

Sent from my iPhone

S M Sohan Consultant ThoughtWorks Canada Suite 1100, 600 6th Ave SW Calgary, AB T2P 0S5 Cell: +1 403 714 2673

On 2011-05-16, at 8:12 PM, jamestelfer reply@reply.github.com wrote:

Use "AbsoluteUri" instead of "ToString()" to avoid removing the escaping from query string parameters.

This means that a URL like "/page.html?query=parameter%20value" will be output with the %20 intact, rather than using a space.

Thanks for the great package, a joy to use :)

Reply to this email directly or view it on GitHub: https://github.com/smsohan/MvcMailer/pull/15

jamestelfer commented 13 years ago

No probs mate. Any idea on the timing of the next release? I'm already using the tip for the web.config URL setting, but I'd prefer to use a release version.

Thanks again for a well thought out package. Razor is great, but it's the scaffolding and the clean code that's generated that makes MvcMailer a winner.