search

smss-dev / moodle-local_artena

Moodle local plugin to support an interface with the Artena SMS
2 stars 3 forks source link

it would be good to clarify why custom web services have been written. #7

Open danmarsden opened 8 years ago

danmarsden commented 8 years ago

Moodle provides a number of webservices that delete courses/obtain course category listings etc and it seems that you implement your own services instead of re-using the existing core functions. It would be good if you could clarify why you have done this - possibly by adding detail in the phpdoc comments of each function or if possible migrate/re-use some of the existing core functions even if you wrap your own webservice function names around the core functions? - would help to decrease the code, make it easier to maintain on your end too.

danmarsden commented 8 years ago

another one that looks weird is the custom create_group webservice functions - if you need your own function names it would be better if you could leverage existing code to create/remove the groups.