search

smss-dev / moodle-local_artena

Moodle local plugin to support an interface with the Artena SMS
2 stars 3 forks source link

attendance web service functions should check to see if attendance is installed. #8

Open danmarsden opened 8 years ago

danmarsden commented 8 years ago

mod_attendance is not a core plugin so the could should not assume that it exists. You should check to see if the attendance plugin is installed before trying to query attendance related tables.

danmarsden commented 8 years ago

i see you've removed the attendance code? - all you really needed to do was wrap it in a call to see if the attendance tables exist or if the attendance code exists before running the functions that query the db?

smss-dev commented 8 years ago

I was pressed for time and that code isn't complete; I've retained it locally until we get around to implementing the Artena side of things, at which point I'll reintroduce.

danmarsden commented 8 years ago

cool - will be nice to see it there. FYI I'm the maintainer of the Attendance plugin too so let me know if you have any issues or changes you would like to make to the attendance code to make it easier for you to use.

danmarsden commented 7 years ago

looks like you've added this back now with some more checks - cool - I haven't been able to test it because the client who asked me to look at this doesn't use the attendance plugin - but if you think it's all sorted you should probably close this one off? - thanks!