search

smstuebe / xamarin-fingerprint

Xamarin and MvvMCross plugin for authenticate a user via fingerprint sensor
Microsoft Public License
490 stars 115 forks source link

Android SetConfirmationRequired #192

Closed domagojmedo closed 3 years ago

domagojmedo commented 3 years ago

Is there a reason why SetConfirmationRequired is commented out in Android implementation.

https://github.com/smstuebe/xamarin-fingerprint/blob/0fc44bc84cf7a33d46f78fb34703c36d2e29a8ad/src/Plugin.Fingerprint/Platforms/Android/FingerprintImplementation.cs#L112

Would you be open to a PR that adds it as a property in config?

smstuebe commented 3 years ago

Yes because it was not supported by the AndroidX binding. I'll have a look if it's now available in the binding. I never checked it again after updating it. And I'd need to check if there is a similar setting for iOS. I wanted to set it to false because this would be the same behavior as on iOS. And often the users of the plugin have struggles understanding, that some settings in the authentication configs are only available on some platforms - even if it's documented :/

Thanks for the hint.

domagojmedo commented 3 years ago

It's available in bindings now

smstuebe commented 3 years ago

It's in v2.1.2. Please give feedback

domagojmedo commented 3 years ago

It works 👍