search

smstuebe / xamarin-fingerprint

Xamarin and MvvMCross plugin for authenticate a user via fingerprint sensor
Microsoft Public License
490 stars 115 forks source link

System cancels being reported as "unknown errors" rather than cancellation #209

Open mlyrstad opened 2 years ago

mlyrstad commented 2 years ago

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather. Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

There are cancel results, due to iOS actions, which are being reported as "unknown errors" when they should be reported as a form of cancel, so we can act appropriately. The reason for the difference is the need to log eventual actual errors.

Steps to reproduce

  1. Let the app open the authentication system on an iPhone (problem reproduced with face-ID and fingerprint)

  2. Press the iPhone's "home" button, easiest way is to not use the registered finger, so it doesn't recognize your fingerprint

  3. Examine the results

Expected behavior

Should report a cancellation (probably just Canceled?)

Actual behavior

Says "unknown error" => "canceled by the system" or something of the sort

Crashlog

Configuration

Version of the Plugin: e.g. 1.0.0 / 1.0.1-alpha3 2.1.4

Platform: e.g. iOS 10.1 / Android 4.4 / ... (including version!!! e.g. Android 5.1 / i0S 10) iOS 13.3.1

Device: e.g. HTC Sensation /i Phone 7 ... iPhone 8 Plus

smsissuechecker commented 2 years ago

Hi @mlyrstad,

I'm the friendly issue checker. Thanks for using the issue template :star2: I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

tranb3r commented 1 year ago

This is still not working properly :(