search

smstuebe / xamarin-fingerprint

Xamarin and MvvMCross plugin for authenticate a user via fingerprint sensor
Microsoft Public License
490 stars 115 forks source link

Fix CA1416 warnings #226

Open jfversluis opened 1 year ago

jfversluis commented 1 year ago

Fixes #222

jfversluis commented 1 year ago

@buyaa-n does this make sense at all?

buyaa-n commented 1 year ago

@buyaa-n does this make sense at all?

Because I do not know where/what warnings you are encountering I am not sure if they makes sense.

EDIT: After reading the issue again it seems the library somehow got assembly level attribute(s), If that is the case the issue is in the build settings as MSBuild adds assembly level attributes for targeted platform, adding individual attributes on API level would most likely has no effect as they could not override parent (assembly level) attribute (in most cases)

HavenDV commented 5 months ago

We are using this as part of the net8 MAUI project and decided to update this project and release the new version as Open-Source: https://github.com/oscoreio/Maui.Biometric I renamed the project, removed some legacy code, got rid of the use of obsolete api platforms, and introduced the AuthenticationStrength abstraction.

I considered this PR as something that could be used in a new project, and limited myself to Runtime checks via OperatingSystem.IsAndroidVersionAtLeast for APIs that require a specific version

https://github.com/oscoreio/Maui.Biometric/blob/02a1bb223ffb14498513a669a23c8d9881dba14b/src/libs/Maui.Biometric/Platforms/Android/AndroidBiometricAuthentication.cs#L49-L65

I think this is enough, but I'm not 100% sure