search

smstuebe / xamarin-fingerprint

Xamarin and MvvMCross plugin for authenticate a user via fingerprint sensor
Microsoft Public License
490 stars 115 forks source link

LAStatus.SystemCancel does not return FingerprintAuthenticationResultStatus.Canceled #234

Open thomasgalliker opened 1 year ago

thomasgalliker commented 1 year ago

I experience a minor issue in following situation:

  1. Start the app on iOS
  2. Start a new local authentication process. Cover the FaceID camera with a finger so that no successful authentication is possible.
  3. While the FaceID dialog is active, lock the iPhone.
  4. NativeAuthenticateAsync tries to handle the returned "LAStatus.SystemCancel" (probably...) which is not mapped to any FingerprintAuthenticationResultStatus. GetResultFromError just returns UnknownError.

Proposed Solution: Wouln't you better map SystemCancel to FingerprintAuthenticationResultStatus.Canceled? https://github.com/smstuebe/xamarin-fingerprint/blob/54807b69044d5f24efac4c0a6e70c7372684d7bc/src/Plugin.Fingerprint/Platforms/Apple/FingerprintImplementation.cs#L154

Thank you for your feedback + thanks for this plugin. Kindly appreciated.

smsissuechecker commented 1 year ago

Hi @thomasgalliker,

I'm the friendly issue checker. It seems like (100.00 %) you haven't used our issue template :cry: I think it is very frustrating for the repository owners, if you ignore them.

If you think it's fine to make an exception, just ignore this message. But if you think it was a mistake to delete the template, please close the issue and create a new one.

Thanks!

thomasgalliker commented 1 year ago

Issue template? I just tapped a line of code and selected "Create new issue from this line". There was no template displayed.🤷🏼‍♂️ I'm sorry. Hope it's still understandable.