smstuebe / xamarin-fingerprint

Xamarin and MvvMCross plugin for authenticate a user via fingerprint sensor
Microsoft Public License
491 stars 116 forks source link

Function AuthenticateAsync in FingerprintImplementationBase.cs #27

Closed hrafnl closed 7 years ago

hrafnl commented 7 years ago

This function currently looks like this:

public async Task<FingerprintAuthenticationResult> AuthenticateAsync(AuthenticationRequestConfiguration authRequestConfig, CancellationToken cancellationToken = new CancellationToken())
        {
            if(await IsAvailableAsync())
                return new FingerprintAuthenticationResult { Status = FingerprintAuthenticationResultStatus.NotAvailable };
            return await NativeAuthenticateAsync(authRequestConfig, cancellationToken);
        }

Shouldn't it read like this:

public async Task<FingerprintAuthenticationResult> AuthenticateAsync(AuthenticationRequestConfiguration authRequestConfig, CancellationToken cancellationToken = new CancellationToken())
        {
            if(await IsAvailableAsync())
                return await NativeAuthenticateAsync(authRequestConfig, cancellationToken);
            return new FingerprintAuthenticationResult { Status = FingerprintAuthenticationResultStatus.NotAvailable };
        }
smstuebe commented 7 years ago

yes, sorry I'll fix it. I wonder how my tests passed o0 Have to investigate it.