search

smstuebe / xamarin-fingerprint

Xamarin and MvvMCross plugin for authenticate a user via fingerprint sensor
Microsoft Public License
494 stars 118 forks source link

SamsungFingerprintImplementation returns wrong error after failed attempts #47

Closed nielscup closed 4 years ago

nielscup commented 7 years ago

Steps to reproduce

  1. Start the sample app on a Samsung device
  2. Press AuthenticateLocalized
  3. Authenticate with your wrong finger until the authenticationdialog disappears: you get the TooManyAttempts message: this is correct
  4. Press AuthenticateLocalized again
  5. Authenticate with your wrong finger again until the authenticationdialog disappears: now you get the failed message: this is not expected because I cannot provide the user with any useful information based on this message.
  6. Press AuthenticateLocalized again
  7. the authenticationdialog disappears: now you get the UnknownError message: this is not expected because I cannot provide the user with any useful information based on this message.

Expected behavior

The same behaviour as a non Samsung device: always show the TooManyAttempts message while fingerprint is locked due to too many attempts.

Actual behavior

see reproduction steps

Crashlog

n/a

Configuration

Version of the Plugin: 1.4.2

Platform: Android 6.0.1

Device: e.g. Tested on Samsung Galaxy S7

smsissuechecker commented 7 years ago

Hi @nielscup,

I'm the friendly issue checker. Thanks for using the issue template :star2: I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

smstuebe commented 4 years ago

2.0.0 has no samsung specific implementation anymore.