Rename ENV vars for better identification

smswithoutborders / SMSWithoutBorders.com

Here is the interface through which users can manage their accounts and store their credentials

https://smswithoutborders.com

GNU General Public License v3.0

23 stars 8 forks source link

Rename ENV vars for better identification #18

Closed sherlockwisdom closed 2 years ago

sherlockwisdom commented 2 years ago

https://github.com/smswithoutborders/smswithoutborders.com/blob/9acf563244ca06cccdfbd57e7771e785b6c707bf/src/pages/Profile.jsx#L77

to enhance devs ability to understand why they need each variable, it's best we rename variables to match the functionalities they are for. Suggesting we rename variable VITE_ROUTER_URL to VITE_GATEWAY_SERVER

nSedrickm commented 2 years ago

We no longer use Vite but the variable is still router could change to Gateway

sherlockwisdom commented 2 years ago

Sorry I don't understand. Currently looking at the naming convention - not sure about the tooling

nSedrickm commented 2 years ago

I see. The build tools define the variable naming conventions. When we used Vite every env variable had to be prefixed with VITE_. Now we prefix them with REACTAPP. i will update ROUTER_URL to GATEWAY_SERVER so it matches current spec

sherlockwisdom commented 2 years ago

Thanks, I will go ahead and close this as soon you make the commit :+1: