smswithoutborders / SMSWithoutBorders.com

Here is the interface through which users can manage their accounts and store their credentials
https://smswithoutborders.com
GNU General Public License v3.0
23 stars 8 forks source link

Low site performance and accessibility scores #38

Closed teyim closed 2 years ago

teyim commented 2 years ago

bandicam 2022-06-15 16-40-15-878

teyim commented 2 years ago

Can i work on this?

nSedrickm commented 2 years ago

Hi @teyim, thanks for catching this.

Sure, it will be great if you could. However, I recommend you work with the dev branch since it has the most recent changes

Also, be sure to checkout our contribution guide to help you get started

Let me know if you have any questions

teyim commented 2 years ago

ok

nSedrickm commented 2 years ago

Hello @teyim. Will you be going forward with this issue?

teyim commented 2 years ago

Hey @nSedrickm ..so sorry about this. Yes, I will.

nSedrickm commented 2 years ago

Ok

teyim commented 2 years ago

Hey, @nSedrickm got some issues while working on this. Firstly, the lighthouse report shows that the 2 main performance issues are

  1. Large content paint
  2. Some resources blocking the first content paint of the page

Looking at this we see that the main possible fixes as suggested by the lighthouse are reducing unused js,eliminate content blocking resources, and eliminating the largest content paint image. Now, comparing our image sizes with optimized webp images, there is little or no difference in size, so I think the image sizes are not really an issue here. Also running a lighthouse diagnosis on the prod build served locally, I get the following results: bandicam 2022-07-20 15-16-51-543 which is a little bit confusing since it shows clearly that, large content paint is not an issue, making it difficult to actually fix this issue. will love your help on this.

nSedrickm commented 2 years ago

Hello @teyim. Thanks for these findings.

We could try optimizing the sites routing. Currently we are only lazy loading the entire app bundle in index.js

Perhaps it will be more performant to lazyload all pages individually. You can take a closer look in App.js where all the routes are defined and the pages folder for all the pages

teyim commented 2 years ago

Ok,this sounds promising..let me look into it .

teyim commented 2 years ago

Hey @nSedrickm ,i have opened a PR for this.please review

nSedrickm commented 2 years ago

Thanks @teyim merged in #43. This issue can be closed