search

smswithoutborders / lib_signal_double_ratchet_python

GNU General Public License v3.0
3 stars 0 forks source link

add: License header in the top of the files in the smswithoutborders_libsig directory. #16

Closed wuX4an closed 2 days ago

wuX4an commented 6 days ago

Response of this issue.

PromiseFru commented 6 days ago

Response of this issue.

[!TIP] To link your pull request (PR) to the relevant issue and ensure that the issue is automatically closed once the PR is merged, you can use GitHub's supported keywords in the PR title.

For example, you can use keywords like "fixes," "closes," or "resolves" followed by the issue number. Here’s a format you can follow:

Fixes #123

This will automatically close issue #123 when the PR is merged.

For more information on this, you can check the GitHub documentation.

wuX4an commented 6 days ago

Response of this issue.

Tip

To link your pull request (PR) to the relevant issue and ensure that the issue is automatically closed once the PR is merged, you can use GitHub's supported keywords in the PR title.

For example, you can use keywords like "fixes," "closes," or "resolves" followed by the issue number. Here’s a format you can follow:

Fixes #123

This will automatically close issue #123 when the PR is merged.

For more information on this, you can check the GitHub documentation.

Thanks for the tip.

I'm learning to contribute to projects and I'm only limited to markdowns and troubleshooting dependency errors in python.

PromiseFru commented 5 days ago

@wuX4an, please resolve the rest of the requested changes so I can merge the PR. 🙂

wuX4an commented 3 days ago

@PromiseFru I already did it, sorry, I didn't know xd.

PromiseFru commented 3 days ago

@PromiseFru I already did it, sorry, I didn't know xd.

Hey @wuX4an, you marked the requests resolved without making the necessary file changes. Please review the comments and update the files, ratchets.py and helpers.py, before marking the conversation as resolved. :)

https://github.com/smswithoutborders/lib_signal_double_ratchet_python/pull/16#discussion_r1775149792 https://github.com/smswithoutborders/lib_signal_double_ratchet_python/pull/16#discussion_r1775160032

wuX4an commented 3 days ago

@PromiseFru I already did it, sorry, I didn't know xd.

Hey @wuX4an, you marked the requests resolved without making the necessary file changes. Please review the comments and update the files, ratchets.py and helpers.py, before marking the conversation as resolved. :)

#16 (comment) #16 (comment)

Oh, F***k. I didn't realize xd