Open salvis opened 9 years ago
Not sure if this is massively relevant BUT... I had a similar issue on an older version of qpsmtpd where dnsbl would not respect whitelists. Each plugin generates information, but does not check others.
I added some bits to the dnsbl plugin in the sub hook_rcpt section that might assist (this is just a pointer - don't read it as gospel !):
my $whitehelo = $connection->notes('whitelisthelo');
if ($whitehelo) {
$self->log(LOGINFO, "Whitelisthelo found $whitehelo");
return OK;
}
else {
$self->log(LOGINFO, "Whitelisthelo not found");
}
my $whitesender = $transaction->notes('whitelistsender');
if ($whitesender) {
$self->log(LOGINFO, "Whitelistsender found $whitesender");
return OK;
}
else {
$self->log(LOGINFO, "Whitelistsender not found");
}
Personally I think that all plugins should honour white/black lists.
Note that your issue seems to be with the naughty plugin but you could get them both to respect whitelists as above.
I think that all plugins should honour white/black lists.
That would be convenient, but #223 is what happens when that thought is taken too far.. ;)
I'm sure every plugin could have its exceptions :-)
At the end of the day it is up to the admin to decide what he wants to pass or block. Getting plugins to honour whitelists is a tool. The admin is the arbiter.
Perhaps some sort of switch per plugin ? Or a conf file 'whitelist enable for plugin x y z'
It still goes back to having code per plugin that will read/honour whitelist output as per my scrappy example above.
Just thinking out loud.
Might save a lot of head scratching with people who enable whitelists but then do not understand why they do no seem to work.....
Here's what I'm seeing in 7-debug-2015-01-22_121515.log:
dns_whitelist_soft waiting for whitelist dns done waiting for whitelist dns, got 1 answers ... name 18.208.239.213.list.dnswl.org got txt record Host 213.239.208.18 is whitelisted: hoststar.ch http://dnswl.org/s?s=2441 Plugin dns_whitelist_soft, hook rcpt returned DECLINED, dnsbl ... naughty disconnecting Plugin naughty, hook data returned DENYHARD, Listed http://www.spamsources.fabel.dk/ip/213.239.208.18
Is it possible to get dnsbl to respect dns_whitelist_soft?
Hans