search

smuellerDD / acvpparser

ACVP Parser for invocation of cryptographic implementations using the ACVP JSON test vectors
https://www.chronox.de/acvpparser
Other
36 stars 27 forks source link

OpenSSL safePrimes not working with ffdhe groups #38

Closed sckoehler closed 3 years ago

sckoehler commented 3 years ago

An OpenSSL safePrimes test works with the MODP groups, but not the ffdhe groups. Adding the ffdhe groups to the switch statement at https://github.com/smuellerDD/acvpparser/blob/master/backends/backend_openssl.c#L2682 seems to work. Is this the right solution?

smuellerDD commented 3 years ago

Am Montag, 23. August 2021, 21:17:39 CEST schrieb sckoehler:

Hi sckoehler,

An OpenSSL safePrimes test works with the MODP groups, but not the ffdhe groups. Adding the ffdhe groups to the switch statement at https://github.com/smuellerDD/acvpparser/blob/master/backends/backend_opens sl.c#L2682 seems to work. Is this the right solution?

Yes, that is the correct location if you are concerned about DSA. Patches are welcome :-)

For DH, it would be openssl_dh_set_param but there I use my own safeprimes and not the ones from OpenSSL.

Ciao Stephan

sckoehler commented 3 years ago

I added PR #43 for this.