codepathreview
commented
9 years ago :+1: Congrats on completing the third project! Great job implementing so many optionals, adding offline support and having compose as a modal.
- Your attention to UI/UX was impressive.
- Good to see you were able to format the timestamp cleanly
- Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being displayed while the user composes a tweet
- Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
- Glad to see you made the compose activity into a dialog instead
- Good to see you added ActiveAndroid annotations to the models
- Good job getting retweet and favorite counts correctly displayed
- Try to add validations on character count and user should not be able to post if count > 140. It should be handled in code instead of having API call fail.
I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.
Week 3 project complete, please review /cc @codepathreview @codepath.