added mouse over function and sample-1.html

smurfy / cloud-zoom

Fork of http://www.professorcloud.com/mainsite/cloud-zoom.htm

111 stars 67 forks source link

Closed baladkb closed 8 years ago

baladkb commented 8 years ago

Hi @smurfy, Sorry for delay, I added the sample-1.html and updated the cloud-zoom.js, please check...

smurfy commented 8 years ago

Thanks, some stuff i don't like: (just looked at the code, but i can fix too)

its not optional
"click" and "mouseover" code is the same, would make sense to create a var method = function().. and use it for both events. (again mouseover thing optional)

baladkb commented 8 years ago

Ok @smurfy, For your reference : sample-1.html use full for users please check ...

baladkb commented 8 years ago

can I give separate pull request for sample-1.html page.

smurfy commented 8 years ago

Just update this one if you have something new. I will look at this later today.

baladkb commented 8 years ago

Ok thanks @smurfy. I'll give PR for sample-1.html.

baladkb commented 8 years ago

@smurfy have You checked the PR?