search

smurfy / fahrplan

QT Application for Public transportation
GNU General Public License v2.0
58 stars 33 forks source link

Mixed languages in travel overview #142

Open stmblfrcr opened 9 years ago

stmblfrcr commented 9 years ago

There are both German and English announcements from DB. img_20141126_122136

leppa commented 9 years ago

We currently request journey data from English version of bahn.de, independently from the application UI language. And the strings are displayed exactly as they're returned by the service. So mixed language announcements is what bahn.de returns and we can do nothing about that, AFAIK.

On the other hand, we can implement requesting from German version of bahn.de when German UI language is set, which should make it return most announcements in German. @smurfy, what do you think?

smurfy commented 9 years ago

Yea we have to look at the code, problem is that we do some mapping based on the data returned. Like "Walk" or stuff like that. Not sure if this is still the case.

Also i would not limit it to german. I guess other backends support multiple languages aswell. (Netherlands, Swiss, Denmark ...)

So its a YES to we should do it :D

leppa commented 9 years ago

Also i would not limit it to german.

Yes, sure. Different backends support different sets of languages. We can make it so that when UI language is supported by the backend, we request in this language. If not, we fall back to English.

smurfy commented 9 years ago

Exactly