search

smutch / meraxes

The Meraxes semi-analytic galaxy formation model.
GNU General Public License v3.0
4 stars 6 forks source link

Include an updated version of the recent 21cmFAST fix #51

Closed BradGreig closed 3 years ago

BradGreig commented 3 years ago

Hey @smutch, yeah, sorry, I was being lazy and trying to add the fix from desktop (so didn't compile it locally to test). Poor form I know. This should be right now.

manodeep commented 3 years ago

Would it be worthwhile to add a GitHub Actions CI to check that code compiles?

smutch commented 3 years ago

Absolutely it would. Unfortunately it's not something I'm going to get the opportunity to tackle any time soon. :( PRs are very welcome though! ;)

manodeep commented 3 years ago

Absolutely it would. Unfortunately it's not something I'm going to get the opportunity to tackle any time soon. :( PRs are very welcome though! ;)

Yup - a PR is precisely what I was thinking. If you note the dependencies (with minimum/sensible versions) and how to initialize the repo + compile, then I am happy to package that up into a GH Actions CI. That would also give a good starting point should you decide to add further testing down the line.

smutch commented 3 years ago

Hey @smutch, yeah, sorry, I was being lazy and trying to add the fix from desktop (so didn't compile it locally to test). Poor form I know. This should be right now.

Legend. Thanks for this @BradGreig!

smutch commented 3 years ago

Absolutely it would. Unfortunately it's not something I'm going to get the opportunity to tackle any time soon. :( PRs are very welcome though! ;)

Yup - a PR is precisely what I was thinking. If you note the dependencies (with minimum/sensible versions) and how to initialize the repo + compile, then I am happy to package that up into a GH Actions CI. That would also give a good starting point should you decide to add further testing down the line.

Amazing. Thanks @manodeep. I'll try and get that to you soon. I've only really used Gitlab's CI before so it would be great to have someone with experience of Github's to set this up.