search

smutch / meraxes

The Meraxes semi-analytic galaxy formation model.
GNU General Public License v3.0
4 stars 6 forks source link

Sn typo #54

Closed qyx268 closed 3 years ago

qyx268 commented 3 years ago

I think it is a typo in case 1 if this is still the Guo+11 model. I also found this parameter actually does not make a significant change to e.g. SMF. But it worths fixing this before tuning the new model.

I also feel that in case 2, even this is supposed to be the same as the mass loading factor, we should use the quantity of SnEjectionNorm and assign the value in the parameter file as the same as the mass loading rather than doing it implicitly in the code.

qyx268 commented 3 years ago

sorry, my master seems to contain previous developement of popiii SF. I'll create a new PR